#4 ✓resolved
Patrick Altman

Clean Up models.py

Reported by Patrick Altman | April 19th, 2008 @ 12:56 AM

Comments and changes to this ticket

  • Patrick Altman

    Patrick Altman April 19th, 2008 @ 12:57 AM

    W: 76: TODO: Convert date fields to python datetime objects

    C: 1: Missing docstring

    C: 24:Toc: Missing docstring

    C: 40:Toc.fromxml: Invalid name "t" (should match [a-z_][a-z0-9_]{2,30}$)

    C: 48:Toc.fromxml: Invalid name "a" (should match [a-z_][a-z0-9_]{2,30}$)

    R: 24:Toc: Too few public methods (1/2)

    C: 54:Album: Missing docstring

    R: 54:Album: Too many instance attributes (14/7)

    C: 76:Album.fromxml: Invalid name "a" (should match [a-z_][a-z0-9_]{2,30}$)

    R: 54:Album: Too few public methods (1/2)

    C:101:Section: Missing docstring

    R:101:Section: Too many instance attributes (8/7)

    C:117:Section.fromxml: Invalid name "s" (should match [a-z_][a-z0-9_]{2,30}$)

    W:128:Section.fromxml: Except doesn't do anything

    W:129:Section.fromxml: No exception type(s) specified

    R:101:Section: Too few public methods (1/2)

    C:137:Image: Missing docstring

    C:144:Image.__init__: Invalid name "isVideo" (should match [a-z_][a-z0-9_]{2,30}$)

    R:137:Image: Too many instance attributes (10/7)

    C:139:Image.__init__: Operator not preceded by a space

    self.album_id=0

    ^

    C:140:Image.__init__: Operator not preceded by a space

    self.section_id=0

    ^

    C:141:Image.__init__: Operator not preceded by a space

    self.image_id=0

    ^

    C:142:Image.__init__: Operator not preceded by a space

    self.filename=""

    ^

    C:143:Image.__init__: Operator not preceded by a space

    self.caption=""

    ^

    C:144:Image.__init__: Operator not preceded by a space

    self.isVideo=False

    ^

    C:145:Image.__init__: Operator not preceded by a space

    self.exif=""

    ^

    C:146:Image.__init__: Operator not preceded by a space

    self.hidden=False

    ^

    C:173:Image.fromxmlArray: Invalid name "fromxmlArray" (should match [a-z_][a-z0-9_]{2,30}$)

    C:173:Image.fromxmlArray: Missing docstring

    C:180:Rendition: Missing docstring

    C:182:Rendition.__init__: Operator not preceded by a space

    self.rendition_type=""

    ^

    C:183:Rendition.__init__: Operator not preceded by a space

    self.height=0

    ^

    C:184:Rendition.__init__: Operator not preceded by a space

    self.width=0

    ^

    C:185:Rendition.__init__: Operator not preceded by a space

    self.filesize=0

    ^

    C:186:Rendition.__init__: Operator not preceded by a space

    self.create_date=None

    ^

    C:187:Rendition.__init__: Operator not preceded by a space

    self.media_type=""

    ^

    C:188:Rendition.__init__: Operator not preceded by a space

    self.url=""

    ^

    C:195:Rendition.fromxml: Invalid name "r" (should match [a-z_][a-z0-9_]{2,30}$)

    R:180:Rendition: Too few public methods (1/2)

  • Patrick Altman

    Patrick Altman April 19th, 2008 @ 05:36 AM

    • State changed from “new” to “resolved”

    (from [b54c0e4db51a52e135608b80320eb953b8d9e6c6]) cleaned up pylint offenders [#4 state:resolved]

    http://github.com/paltman/pyphan...

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

A Python binding to the Phanfare API

People watching this ticket

Tags

Pages